bitcoindevkit / bdk / 9768441986

79%

Build Type

push

github

Committed by notmandatory

Commit Message

Merge bitcoindevkit/bdk#1416: [chain] Change tx_last_seen to `Option<u64>`

af75817d4 ref(tx_graph): Change last_seen to `HashMap<Txid, u64>` (valued mammal)
6204d2c76 feat(tx_graph): Add method `txs_with_no_anchor_or_last_seen` (valued mammal)
496601b8b test(tx_graph): Add test for `list_canonical_txs` (valued mammal)
c4057297a wallet: delete method `insert_anchor` (valued mammal)
b34790c6b ref(tx_graph)!: Rename `list_chain_txs` to `list_canonical_txs` (valued mammal)
2ce4bb4df test(indexed_tx_graph): Add test_get_chain_position (valued mammal)
36f58870c test(wallet): Add test_insert_tx_balance_and_utxos (valued mammal)
bbc19c353 fix(tx_graph)!: Change tx_last_seen to `Option<u64>` (valued mammal)
324eeb3eb fix(wallet)!: Rework `Wallet::insert_tx` to no longer insert anchors (valued mammal)

Pull request description:

  The PR changes the type of last_seen to `Option<u64>` for `txs` member of `TxGraph`.

  This fixes an issue where unbroadcast and otherwise non-canonical transactions were returned from methods `list_chain_txs` and `Wallet::transactions` because every new tx inserted had a last_seen of 0 making it appear unconfirmed.

  fixes #1446
  fixes #1396

  ### Notes to the reviewers

  ### Changelog notice

  Changed
  - Member `last_seen_unconfirmed` of `TxNode` is changed to `Option<u64>`
  - Renamed `TxGraph` method `list_chain_txs` to `list_canonical_txs`
  - Changed `Wallet::insert_tx` to take a single `tx: Transaction` as parameter

  Added
  - Add method `txs_with_no_anchor_or_last_seen` for `TxGraph`
  - Add method `unbroadcast_transactions` for `Wallet`

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [cont... (continued)

Run Details

67 of 73 new or added lines in 3 files covered. (91.78%)

1 existing line in 1 file now uncovered.

11056 of 13287 relevant lines covered (83.21%)

17016.25 hits per line