bitcoindevkit / bdk / 12132903867

79%

push

github

Merge bitcoindevkit/bdk#1737: fix(tx_builder)!: make TxBuilder Send safe, remove Clone trait

<a class=hub.com/bitcoindevkit/bdk/commit/663fb133a4aeac7e50f5d32bdba2b316b17a7e2b">663fb133a fix(tx_builder)!: make TxBuilder Send safe, remove Clone trait (Steve Myers)

Pull request description:

  ### Description

  Inspired by discord chat with @stevenroose as a way to make the `TxBuilder` Send safe.

  See his original patch on 1.0.0-beta.5: https://gist.github.com/stevenroose/f7736dfedfaa64bbdbb0da5875df28fc

  ### Notes to the reviewers

  I had to remove the `Clone` trait on `TxBuilder` but it was only being used in tests.

  ### Changelog notice

  - TxBuilder is now Send safe and does not implement the Clone trait

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [ ] I've added docs for the new feature

ACKs for top commit:
  evanlinjin:
    ACK 663fb133a4aeac7e50f5d32bdba2b316b17a7e2b

Tree-SHA512: 026c0f5f22ae184cf7edd855dbd155cb65f

4 of 4 new or added lines in 2 files covered. (100.0%)

11662 of 13981 relevant lines covered (83.41%)

18880.55 hits per line