bitcoindevkit / bdk / 12227704147

79%

Build Type

push

github

Committed by notmandatory

Commit Message

Merge bitcoindevkit/bdk#1752: Remove serde json dependency from chain crate

1c81cd53f refactor(chain)!: change String by &str for versioned scripts in migrate_schema (nymius)
265b59b6e test(chain): add compatibility test for v0 to v1 sqlite schema migration (nymius)
4ec794015 test(wallet): pattern match ChainPosition::Confirmed in anchors persistence check (nymius)
2eb19f507 refactor(chain)!: move schemas to their own methods (nymius)
5603e9f6d test(chain): use ChangeSet<ConfirmationBlockTime> instead of ChangeSet<BlockId> (nymius)
c3ea54d3b test(wallet): check persisted anchors does not lose data (nymius)
d41cb6219 build(chain): remove serde_json dependency (nymius)
7319f5100 refactor(chain)!: remove AnchorImpl wrapper for Anchor implementors (nymius)
b587b0fca refactor(chain)!: impl sqlite for ConfirmationBlockTime anchored changesets (nymius)

Pull request description:

  ### Description

  As expressed by @LLFourn _We want to not depend on serde_json. If we keep it around for serializing anchors we won't be able to remove it in the future because it will always be needed to do migrations_
  Currently there is only one widely used anchor, `ConfirmationBlockTime`.

  The decision was to constrain support to just be for a single anchor type ConfirmationBlockTime. The anchor table will represent all fields of `ConfirmationBlockTime`, each one in its own column.

  The reasons:

  - No one is using rusqlite with any other anchor type, and if they are, they can do something custom anyway.
  - The anchor representation may change in the future, supporting for multiple Anchor types here will cause more problems for migration later on.

  Resolves #1695

  ### Notes to the reviewer... (continued)

Run Details

181 of 182 new or added lines in 2 files covered. (99.45%)

1 existing line in 1 file now uncovered.

11803 of 14103 relevant lines covered (83.69%)

18823.51 hits per line