Ran
|
Jobs
1
|
Files
50
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
push
github
Merge bitcoindevkit/bdk#1658: fix(wallet)!: Improve test utilities b0dc3ddd3 feat(wallet)!: make `seen_at` mandatory for `Wallet::apply_update_at` (志宇) 00c568d4c revert(wallet)!: rm `Wallet::unbroadcast_transactions` (志宇) 200a16d27 fix(wallet)!: delete method `insert_tx` (valued mammal) ab278844a test(wallet): improve usage of test utils (valued mammal) 9bdf4cb98 chore: fix imports (valued mammal) 28d806123 test(wallet): fix test descriptor getters (valued mammal) 3135e291d test(wallet): add helpers to `test_utils` (valued mammal) 823bb39fc feat(wallet): add module `test_utils` (valued mammal) 297bd9a51 test(wallet): refactor helper `insert_anchor_from_conf` (valued mammal) Pull request description: Follow up to #1643, refactor `insert_anchor_from_conf` to just insert an anchor of type `ConfirmationBlockTime` ### Notes to the reviewers The PR introduces a public `test_utils` module and "test-utils" cargo feature that exposes common helpers such as `get_funded_wallet`. Credit to #1492 for inspiring that idea. Usage of test utilities is enhanced overall, and tests are less dependent on problematic APIs that may be removed in the future. ### Changelog notice - `bdk_wallet`: Added "test-utils" feature flag that exposes common helpers for testing and development - Removed methods `Wallet::insert_tx`, `Wallet::insert_checkpoint`, `Wallet::unbroadcast_transactions` ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing * [x] I've added docs for the new feature * [... (continued)
146 of 146 new or added lines in 3 files covered. (100.0%)
1 existing line in 1 file now uncovered.11501 of 13879 relevant lines covered (82.87%)
13588.72 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
1 |
89.1 |
0.0% | crates/wallet/src/descriptor/mod.rs |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 11790844139.1 | 50 |
82.87 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|