bitcoindevkit / bdk / 7861140473

84%

push

github

Merge bitcoindevkit/bdk#1335: fix(chain): tx_graph::ChangeSet::is_empty

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/13ab5a835d59341e387fbbefec12fe4f48e5f3c8">13ab5a835<a href="https://github.com/bitcoindevkit/bdk/commit/420e929463382ac08c811b2e559f64f26436be67"> chore(chain): Improve TxGraph::ChangeSet docs (LLFourn)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/dbbd51424284a960a95c3801b02dc1973322725f">dbbd51424</a><a href="https://github.com/bitcoindevkit/bdk/commit/420e929463382ac08c811b2e559f64f26436be67"> fix(chain)!: rm duplicate `is_empty` method in tx graph changeset (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/ae00e1ee7b95c622fc3992c0804dd4b4517efc7b">ae00e1ee7</a> fix(chain): tx_graph::ChangeSet::is_empty (LLFourn)

Pull request description:

  🙈

  ### Changelog notice

  - Fix bug in `tx_graph::ChangeSet::is_empty` where is returns true even when it wasn't empty

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing

ACKs for top commit:
  LLFourn:
    Self-ACK: 13ab5a835d59341e387fbbefec12fe4f48e5f3c8
  evanlinjin:
    ACK 13ab5a835d59341e387fbbefec12fe4f48e5f3c8

Tree-SHA512: b9f1f17fd4b32da3f008c2e1c38bcefbcfd

9316 of 11460 relevant lines covered (81.29%)

5658.58 hits per line