bitcoindevkit / bdk / 6999525367

79%

push

github

Merge bitcoindevkit/bdk#1225: esplora: fix incorrect gap limit check in blocking client

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/43aed386bc33f8dfca53ea2ec166dea1ce3d42d3">43aed386b<a href="https://github.com/bitcoindevkit/bdk/commit/55b680c194b218061254ea898d892c9a5e4cdd3b"> esplora: also test the gap limit bounds in the async client (Antoine Poinsot)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/cb713e5b8c74181518e8cfcd4095c862bc73f014">cb713e5b8</a><a href="https://github.com/bitcoindevkit/bdk/commit/55b680c194b218061254ea898d892c9a5e4cdd3b"> esplora: also fix the gap limit check in the async client (Antoine Poinsot)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/2c4e90a76fea51cb7381242f55b1ca0f02e20d4e">2c4e90a76</a><a href="https://github.com/bitcoindevkit/bdk/commit/55b680c194b218061254ea898d892c9a5e4cdd3b"> esplora: scan gap limit bounds testing (Antoine Poinsot)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/18bd3296170e64aee6870cd96dde52a0078bbcb1">18bd32961</a> esplora: fix incorrect gap limit check in blocking client (Antoine Poinsot)

Pull request description:

  The gap limit was checked such as if the last_index was not None but the last_active_index was, we'd consider having reached it. But the last_index is never None for this check. This effectively made it so the gap limit was always 1: if the first address isn't used last_active_index will be None and we'd return immediately.

  Fix this by avoiding error-prone Option comparisons and correctly checking we've reached the gap limit before breaking out of the loop.

ACKs for top commit:
  danielabrozzoni:
    ACK 43aed386bc33f8dfca53ea2ec166dea1ce3d42d3
  evanlinjin:
    ACK 43aed386bc33f8dfca53ea2ec166dea1ce3d42d3

Tree-SHA512: c6a172e0659f0bea88c83f90c4f84487f03

10 of 10 new or added lines in 2 files covered. (100.0%)

8819 of 10961 relevant lines covered (80.46%)

5738.24 hits per line