Ran
|
Jobs
1
|
Files
46
|
Run time
1min
|
Badge
README BADGES
|
push
github
Merge bitcoindevkit/bdk#1514: refactor(wallet)!: rework persistence, changeset, and construction 64eb57634 chore(wallet): Fix ChangeSet::merge (LLFourn) 8875c92ec chore(wallet): Fix descriptor mismatch error keychain (LLFourn) 2cf07d686 refactor(chain,wallet)!: move rusqlite things into it's own file (志宇) 93f9b83e2 chore(chain): rm unused `sqlite` types (志宇) 892b97d44 feat(chain,wallet)!: Change persist-traits to be "safer" (志宇) 3aed4cf17 test(wallet): ensure checks work when loading wallet (志宇) af4ee0fa4 refactor(wallet)!: Make `bdk_wallet::ChangeSet` non-exhaustive (志宇) 22d02ed3d feat!: improve wallet building methods (志宇) eb73f0659 refactor!: move `WalletChangeSet` to `bdk_wallet` and fix import paths (志宇) 6b4300195 feat!: Rework sqlite, changesets, persistence and wallet-construction (志宇) Pull request description: Closes #1496 Closes #1498 Closes #1500 ### Description Rework sqlite: Instead of only supported one schema (defined in `bdk_sqlite`), we have a schema per changeset type for more flexiblity. * rm `bdk_sqlite` crate (as we don't need `bdk_sqlite::Store` anymore). * add `sqlite` feature on `bdk_chain` which adds methods on each changeset type for initializing tables, loading the changeset and writing. Rework changesets: Some callers may want to use `KeychainTxOutIndex` where `K` may change per descriptor on every run. So we only want to persist the last revealed indices by `DescriptorId` (which uniquely-ish identifies the descriptor). * rm `keychain_added` field from `keychain_txout`'s changeset. * Add `keychain_added` to `CombinedChangeSet` (which is renamed to `WalletChangeSet`). Rework persistence: add... (continued)
817 of 1088 new or added lines in 12 files covered. (75.09%)
33 existing lines in 7 files now uncovered.10946 of 13369 relevant lines covered (81.88%)
16192.73 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
1 |
80.71 |
-1.47% | crates/chain/src/indexer/keychain_txout.rs |
3 |
91.51 |
-1.58% | crates/chain/src/indexed_tx_graph.rs |
3 |
50.0 |
crates/chain/src/lib.rs | |
9 |
83.2 |
-0.63% | crates/chain/src/local_chain.rs |
19 |
86.13 |
crates/wallet/src/wallet/changeset.rs | |
19 |
79.79 |
crates/wallet/src/wallet/persisted.rs | |
31 |
83.65 |
-0.35% | crates/wallet/src/wallet/mod.rs |
34 |
46.03 |
crates/chain/src/persist.rs | |
50 |
57.98 |
crates/wallet/src/wallet/params.rs | |
102 |
71.59 |
crates/chain/src/rusqlite_impl.rs |
Lines | Coverage | ∆ | File |
---|---|---|---|
1 |
58.33 |
-2.78% | crates/wallet/src/types.rs |
2 |
76.67 |
-1.67% | crates/chain/src/chain_data.rs |
2 |
83.65 |
-0.35% | crates/wallet/src/wallet/mod.rs |
3 |
82.6 |
-0.57% | crates/wallet/src/wallet/signer.rs |
5 |
91.51 |
-1.58% | crates/chain/src/indexed_tx_graph.rs |
6 |
80.71 |
-1.47% | crates/chain/src/indexer/keychain_txout.rs |
14 |
90.56 |
-2.05% | crates/wallet/src/descriptor/mod.rs |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 10033071784.1 | 46 |
81.88 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|