bitcoindevkit / bdk / 6421722469

79%

push

github

Merge bitcoindevkit/bdk#1064: Better tests for transaction conflict handling

6d601a7e8 test(chain): Add test for conflicting transactions (Daniela Brozzoni)
48ca95b54 test(chain): Add test for walk_ancestors (Daniela Brozzoni)
59a2403e2 test(chain): Introduce TxTemplate (Daniela Brozzoni)
6e511473a test(chain): add block_id! utility macro (Daniela Brozzoni)
62de55f12 fix(chain): Consider conflicting ancestors in... ...try_get_chain_pos (Daniela Brozzoni)
a3e8480ad doc(chain): Clarify direct_conflicts_of_tx's docs (Daniela Brozzoni)
4742d88ea feat(chain): Introduce TxAncestors, walk_ancestors (Daniela Brozzoni)
2f26eca60 fix(chain): TxDescendants performs a BFS (Daniela Brozzoni)
486e0e143 doc(chain): Fix typos (Daniela Brozzoni)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  Fixes #1063.

  This PR introduces a new `TxTemplate` struct to test different transaction conflict scenarios in `TxGraph`.
  The following transaction conflict scenarios are tested:
  - 2 unconfirmed txs with different last_seens conflict. The most recent tx should be the only tx that appears in the list methods.
  - 3 unconfirmed txs with different last_seens conflict. The most recent tx should be the only tx that appears in the list methods.
  - An unconfirmed tx U conflicts with a tx anchored in orphaned block O. O has higher last_seen. O should be the only tx that appears in the list methods.
  - An unconfirmed tx U conflicts with a tx anchored in orphaned block O. U has higher last_seen. U should be the only tx that appears in the list methods.
  - Multiple unconfirmed txs conflict with a confirmed tx. None of... (continued)

133 of 133 new or added lines in 1 file covered. (100.0%)

8326 of 10294 relevant lines covered (80.88%)

5279.45 hits per line