bitcoindevkit / bdk / 7585810654
83%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 39
Run time 4s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.829% (-0.03%) from 79.858%
7585810654

push

github

evanlinjin 
Merge bitcoindevkit/bdk#1292: fix(store): Remove lifetime

<a class=hub.com/bitcoindevkit/bdk/commit/e6433fb2c1526cff37e3a17cc71986759ebac30f">e6433fb2c<a href="https://github.com/bitcoindevkit/bdk/commit/3fa44a58ec348fe7fa413ca96e8bf744c6210647"> feat(persist): Add stage_and_commit to Persist (LLFourn)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/0bee46e75bc99112abc15de59984e6059ff874e5">0bee46e75</a> fix(store): Remove lifetime (LLFourn)

Pull request description:

  Remove gratuitous use of lifetimes in the main persistence struct `Store`. Having lifetimes on this means that you have to keep the magic bytes alive longer than the database which is particularly offensive if you have to send the database to another thread. On top of that the bytes aren't even read.

ACKs for top commit:
  evanlinjin:
    ACK e6433fb2c1526cff37e3a17cc71986759ebac30f

Tree-SHA512: 7f6d9d609702294af13d75bdecbef677ffc

8976 of 11244 relevant lines covered (79.83%)

5910.41 hits per line

Jobs
ID Job ID Ran Files Coverage
1 7585810654.1 39
79.83
 GitHub Action Run
Source Files on build 7585810654