bitcoindevkit / bdk / 12955783354

79%

push

github

Merge bitcoindevkit/bdk#1805: feat(wallet): support Testnet4 in valid networks

<a class=hub.com/bitcoindevkit/bdk/commit/c8e8a6a57fe17c683584774834a71a1bca5190d4">c8e8a6a57 feat(wallet): support Testnet4 in valid networks (valued mammal)

Pull request description:

  Adds support for `Testnet4` in valid networks.

  fixes #1429

  ### Notes to the reviewers

  The `Testnet4` variant is included in `keys::any_network` and `keys::test_networks`. Tests are updated accordingly and a new assertion is added to `test_descriptor_from_str_with_keys_network` checking the result of `into_wallet_descriptor` when the specified network is `Network::Testnet4`.

  ### Changelog notice

  Added:
  - `Wallet` can now be constructed using `Network::Testnet4`

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK c8e8a6a57fe17c683584774834a71a1bca5190d4

Tree-SHA512: e52642a793df1e1feb922d40a60c1e136a4

18 of 18 new or added lines in 4 files covered. (100.0%)

11981 of 13936 relevant lines covered (85.97%)

20165.69 hits per line