bitcoindevkit / bdk / 15061926453

79%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#1950: feat!(chain): implement `first_seen` tracking

<a class=hub.com/bitcoindevkit/bdk/commit/8b17bcfc03c39cd35415742bc31293b7969d1024">8b17bcfc0 feat!(chain): implement `first_seen` tracking (uvuvuwu)

Pull request description:

  ### Description

  This PR solves issue #1947 by implementing `first_seen` tracking.

  * Added `first_seen` field to `TxGraph` and `ChangeSet` so that `first_seen` timestamp can be added when inserting a new seen-at using `insert_seen_at`.

  * `first_seen` added to `TxNode` as a way to retrieve the first-seen timestamp for a transaction.

  * `first_seen` added to `ChainPosition::Unconfirmed` to order unconfirmed transactions by `first_seen`.

  * New tests have been added for the above described functionalities.

  ### Changelog notice

  * Add tracking first-seen timestamps of transactions

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  evanlinjin:
    ACK 8b17bcfc03c39cd35415742bc31293b7969d1024

Tree-SHA512: effb957047abefa91db520d935c1957c9d5

Run Details

98 of 107 new or added lines in 2 files covered. (91.59%)

1 existing line in 1 file now uncovered.

5396 of 6513 relevant lines covered (82.85%)

29539.98 hits per line