bitcoindevkit / bdk / 6847841080

84%

Build Type

push

github

Committed by danielabrozzoni

Commit Message

Merge bitcoindevkit/bdk#1200: fix(bdk): Check if we're using the correct internal key before signing

<a class=hub.com/bitcoindevkit/bdk/commit/e553231eae45dc6d263a1fce2a3a9c46f6af2510">e553231ea fix(bdk): Check if we're using the correct... ...internal key before signing (Daniela Brozzoni)

Pull request description:

  ### Description

  Fixes #1142

  We would previously sign with whatever x_only_pubkey we had in hand, without first checking if it was the right key or not. This effectively meant that adding multiple taproot PrivateKey signers would produce unbroadcastable transactions.

  ### Changelog notice

  - Fix a bug related to taproot signing with internal keys. We would previously sign with the first private key we had, without checking if it was the correct internal key or not.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK e553231eae45dc6d263a1fce2a3a9c46f6af2510

Tree-SHA512: c4abbcd27939f0b0159960a6c863f8ca145

Run Details

17 of 17 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

8594 of 10568 relevant lines covered (81.32%)

5933.65 hits per line