bitcoindevkit / bdk / 13769960617

79%

push

github

Merge bitcoindevkit/bdk#1841: Generalize `add_recipient` to accept `Address`

<a class=hub.com/bitcoindevkit/bdk/commit/de2c44fc183b3b43816cfe6c868c8cea7d749d7b">de2c44fc1 feat(wallet): generalize `add_recipient` to accept `Address` (Rob N)

Pull request description:

  ### Description

  I would imagine many users would be handling a `Address<NetworkChecked>` when building a transaction. They may pass this structure directly with this patch, or continue to use `ScriptBuf`.

  ### Notes to the reviewers

  To my knowledge this is non-breaking, but it is a change in the function signature so I am not sure.

  ### Changelog notice

  Accept any type that is convertible to a `ScriptBuf` in `TxBuilder::add_recipient`

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    reACK de2c44fc183b3b43816cfe6c868c8cea7d749d7b

Tree-SHA512: 42a2661908c8c441c77dab3721bebafd93d

6 of 6 new or added lines in 1 file covered. (100.0%)

12150 of 14324 relevant lines covered (84.82%)

14631.84 hits per line