bitcoindevkit / bdk / 10547408537

83%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#1569: Introduce `bdk_core`

a5d076f21 chore(core)!: s/tx_graph::Update/TxUpdate/ (LLFourn)
dafb9aaef feat(bitcoind_rpc)!: depend on `bdk_core` instead of `bdk_chain` (志宇)
fea8eede7 feat(esplora)!: depend on `bdk_core` instead of `bdk_chain` (志宇)
0d302f5f2 feat(electrum)!: depend on `bdk_core` instead of `bdk_chain` (志宇)
ab0315d14 feat!: move `spk_client`s to `bdk_core` (志宇)
bdea871a0 feat!: move `tx_graph::Update` to `bdk_core` (志宇)
77e31c71a feat!: move `CheckPoint` to `bdk_core` (志宇)
a86c878a6 refactor(chain): change `CheckPoint::apply_changeset` (志宇)
6f7626ad0 feat!: introduce `bdk_core` (志宇)

Pull request description:

  Based on #1568
  Closes #1543

  ### Description

  Introduce `bdk_core` crate. Move types over from `bdk_chain`. Chain sources (`bdk_electrum`, `bdk_esplora` and `bdk_bitcoind_rpc`) now only depend on `bdk_core`.

  ### Notes to the reviewers

  Please review commit-by-commit. I've moved things over, but slight API changes were necessary (mentioned in the commit messages).

  ### Changelog notice

  * Add `bdk_core` crate which contains core types that were previously in `bdk_chain`. Including: `BlockId`, `ConfirmationBlockTime`, `CheckPoint`, `CheckPointIter`, `tx_graph::Update` and `spk_client`-types.
  * Change chain sources (`bdk_esplora`, `bdk_electrum` and `bdk_bitcoind_rpc`) to only depend on `bdk_core`.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  LLFourn:
    Self-ACK: a5d076f215cd91173f55bda... (continued)

Run Details

297 of 359 new or added lines in 17 files covered. (82.73%)

3 existing lines in 2 files now uncovered.

11230 of 13682 relevant lines covered (82.08%)

14058.44 hits per line