bitcoindevkit / bdk / 8781956347

79%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#1380: Simplified `EsploraExt` API

96a9aa6e6 feat(chain): refactor `merge_chains` (志宇)
2f22987c9 chore(chain): fix comment (志宇)
daf588f01 feat(chain): optimize `merge_chains` (志宇)
77d35954c feat(chain)!: rm `local_chain::Update` (志宇)
1269b0610 test(chain): fix incorrect test case (志宇)
72fe65b65 feat(esplora)!: simplify chain update logic (志宇)
eded1a7ea feat(chain): introduce `CheckPoint::insert` (志宇)
519cd75d2 test(esplora): move esplora tests into src files (志宇)
a6e613e6b test(esplora): add `test_finalize_chain_update` (志宇)
494d25349 feat(testenv): add `genesis_hash` method (志宇)
886d72e3d chore(chain)!: rm `missing_heights` and `missing_heights_from` methods (志宇)
bd62aa0fe feat(esplora)!: remove `EsploraExt::update_local_chain` (志宇)
1e9979398 feat(testenv): add `make_checkpoint_tip` (志宇)

Pull request description:

  Fixes #1354

  ### Description

  Built on top of both #1369 and #1373, we simplify the `EsploraExt` API by removing the `update_local_chain` method and having `full_scan` and `sync` update the local chain in the same call. The `full_scan` and `sync` methods now takes in an additional input (`local_tip`) which provides us with the view of the `LocalChain` before the update. These methods now return structs `FullScanUpdate` and `SyncUpdate`.

  The examples are updated to use this new API. `TxGraph::missing_heights` and `tx_graph::ChangeSet::missing_heights_from` are no longer needed, therefore they are removed.

  Additionally, we used this opportunity to simplify the logic which updates `LocalChain`. We got rid of the... (continued)

Run Details

952 of 1037 new or added lines in 5 files covered. (91.8%)

7 existing lines in 3 files now uncovered.

10259 of 11974 relevant lines covered (85.68%)

17915.31 hits per line