bitcoindevkit / bdk / 9021697036

79%

Build Type

push

github

Committed by notmandatory

Commit Message

Merge bitcoindevkit/bdk#1203: Include the descriptor in `keychain::Changeset`

86711d4f4 doc(chain): add section for non-recommended K to descriptor assignments (Daniela Brozzoni)
de53d7219 test: Only the highest ord keychain is returned (Daniela Brozzoni)
9d8023bf5 fix(chain): introduce keychain-variant-ranking to `KeychainTxOutIndex` (志宇)
6c8748124 chore(chain): move `use` in `indexed_tx_graph.rs` so clippy is happy (志宇)
537aa03ae chore(chain): update test so clippy does not complain (志宇)
ed117de7a test(chain): applying changesets one-by-one vs aggregate should be same (志宇)
6a3fb849e fix(chain): simplify `Append::append` impl for `keychain::ChangeSet` (志宇)
1d294b734 fix: Run tests only if the miniscript feature is.. ..enabled, enable it by default (Daniela Brozzoni)
0e3e136f6 doc(bdk): Add instructions for manually inserting... ...secret keys in the wallet in Wallet::load (Daniela Brozzoni)
76afccc55 fix(wallet): add expected descriptors as signers after creating from wallet::ChangeSet (Steve Myers)
4f05441a0 keychain::ChangeSet includes the descriptor (Daniela Brozzoni)
8ff99f27d ref(chain): Define test descriptors, use them... ...everywhere (Daniela Brozzoni)
b9902936a ref(chain): move `keychain::ChangeSet` into `txout_index.rs` (志宇)

Pull request description:

  Fixes #1101

  - Moves keychain::ChangeSet inside `keychain/txout_index.rs` as now the `ChangeSet` depends on miniscript
  - Slightly cleans up tests by introducing some constant descriptors
  - The KeychainTxOutIndex's internal SpkIterator now uses DescriptorId
  instead of K. The DescriptorI... (continued)

Run Details

384 of 459 new or added lines in 5 files covered. (83.66%)

9 existing lines in 2 files now uncovered.

10593 of 12867 relevant lines covered (82.33%)

16612.67 hits per line