Ran
|
Jobs
1
|
Files
44
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
push
github
Merge bitcoindevkit/bdk#1468: feat: use `Weight` type instead of `usize` <a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/438cd4682d14b5f4c6c9c653c9f05ccaaecb815d">438cd4682 refactor(wallet)!: change WeightedUtxo to use Weight type (Leonardo Lima) Pull request description: fixes #1466 depends on #1448 <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description This PR is a follow-up on top of #1448, and should be rebased and merged after it, it uses the rust-bitcoin `Weight` type instead of the current `usize` usage. NOTE: ~~It also adds a new `MiniscriptError` variant, and remove the `.unwrap()` usage.~~ As suggested I'll address this on another issue #1485, trying to reproduce the error first. <!-- Describe the purpose of this PR, what's being adding and/or fixed --> ### Notes to the reviewers It should be ready to review after #1448 gets merged. <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> ### Changelog notice - Change `WeightedUtxo` `satisfaction_weight` has been changed to use `Weight` type. - Change `TxBuilder` methods `add_foreign_utxo` and `add_foreign_utxo_with_sequence` to expect `Weight` as `satisfaction_weight` type. <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: storopoli: Anyways, ACK 438cd4682d14b5f4c6c9c653c9f05ccaaecb815d notmandatory: ACK 438cd4682d14b5f4c6c9c653c9f05ccaaecb815d Tree-SHA512: 1998fe6596732c1a11d05e6f45837af002f
17 of 20 new or added lines in 3 files covered. (85.0%)
11048 of 13307 relevant lines covered (83.02%)
16726.66 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
3 |
82.94 |
-0.08% | crates/wallet/src/wallet/mod.rs |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 9687828408.1 | 44 |
83.02 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|