bitcoindevkit / bdk / 10838877402

83%

push

github

Merge bitcoindevkit/bdk#1605: fix(wallet): fix SingleRandomDraw to error if insufficient funds

<a class=hub.com/bitcoindevkit/bdk/commit/22a2f83db5df5f48974a06deef6b45d41a05ef3b">22a2f83db fix(wallet): fix SingleRandomDraw to throw an error if insufficient funds (Steve Myers)

Pull request description:

  ### Description

  * fix SingleRandomDraw to error if insufficient funds
  * fixed spelling and clippy errors (see: https://github.com/bitcoindevkit/bdk/pull/1581#discussion_r1756936178)
  * updated tests to check for error variant instead of a panic

  ### Notes to the reviewers

  Since the single random draw algo can be used on its own it needs to be able to return an insufficient funds error. I think the reason we didn't catch this before is that single random draw already check for sufficient required + optional utxo amounts and returns the insufficient funds error.

  ### Changelog notice

  * fix SingleRandomDraw coin selection to error if there are insufficient funds for a requested payment amount.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 22a2f83db5df5f48974a06deef6b45d41a05ef3b

Tree-SHA512: c434003ea9d9d8f72b7a1099883da75dceb

124 of 124 new or added lines in 1 file covered. (100.0%)

11297 of 13678 relevant lines covered (82.59%)

14585.97 hits per line