bitcoindevkit / bdk / 8124101667

79%

push

github

Merge bitcoindevkit/bdk#1349: Fix `KeychainTxOutIndex::lookahead_to_target`

<a class=hub.com/bitcoindevkit/bdk/commit/b290b2950221578d73c3194a1accfd080f83631a">b290b2950<a href="https://github.com/bitcoindevkit/bdk/commit/c3544c9b8c9453faf8c062cbe3a13ed7f9514024"> test(chain): change test case comments to docstring (志宇)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/c151d8fd230fb87f27aadb965157f94f01f021a2">c151d8fd2</a> fix(chain): `KeychainTxOutIndex::lookahead_to_target` (志宇)

Pull request description:

  ### Description

  This method was not used (so it was untested) and it was not working. This fixes it.

  The old implementation used `.next_store_index` which returned the keychain's last index stored in `.inner` (which include lookahead spks). This is WRONG because `.replenish_lookahead` needs the difference from last revealed.

  ### Changelog notice

  Fix `KeychainTxOutIndex::lookahead_to_target`

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [x] I've added tests to reproduce the issue which are now passing

ACKs for top commit:
  notmandatory:
    ACK b290b2950221578d73c3194a1accfd080f83631a

Tree-SHA512: af50c6af191d791e85c1c79591437182539

6 of 6 new or added lines in 1 file covered. (100.0%)

9351 of 11485 relevant lines covered (81.42%)

5648.02 hits per line