bitcoindevkit / bdk / 5901842014

79%

push

github

Merge bitcoindevkit/bdk#1065: refactor!(chain): Unify ChangeSet nomenclature

<a class=hub.com/bitcoindevkit/bdk/commit/62f253103c3fd158ad66a0bba11399e7083226f2">62f253103<a href="https://github.com/bitcoindevkit/bdk/commit/d6bcd9b725a63b5db9157fb11a827a472ddcf73d"> ci: Update tokio version (Daniela Brozzoni)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/80f5ecf3be2550808f1bf1870df2504c09395dee">80f5ecf3b</a><a href="https://github.com/bitcoindevkit/bdk/commit/d6bcd9b725a63b5db9157fb11a827a472ddcf73d"> feat(chain): Add `initial_changeset` to graphs (Daniela Brozzoni)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/ea50b6a932ca492f27ac4aaea93c6b6ba11fa0e8">ea50b6a93</a> refactor!(chain): Unify ChangeSet nomenclature (Daniela Brozzoni)

Pull request description:

  Solves #1022

  ### Changelog notice

  Rename `indexed_tx_graph::IndexedAdditions` to `indexed_tx_graph::ChangeSet`
  Rename `indexed_tx_graph::IndexedAdditions::graph_additions` to `indexed_tx_graph::ChangeSet::graph`
  Rename `indexed_tx_graph::IndexedAdditions::index_additions` to `indexed_tx_graph::ChangeSet::indexer`
  Rename `tx_graph::Additions` to `tx_graph::ChangeSet`
  Rename `keychain::DerivationAdditions` to `keychain::ChangeSet`
  Rename `CanonicalTx::node` to `CanonicalTx::tx_node`
  Rename `CanonicalTx::observed_as` to `CanonicalTx::chain_position`
  Rename `LocalChangeSet` to `WalletChangeSet`
  Rename `LocalChangeSet::chain_changeset` to `WalletChangeSet::chain`
  Rename `LocalChangeSet::indexed_additions` to `WalletChangeSet::indexed_tx_graph`
  Rename `LocalUpdate` to `WalletUpdate`
  Make `TxGraph::determine_changeset` `pub(crate)`
  Add `TxGraph::initial_changeset`
  Add `IndexedTxGraph::initial_changeset`
  Remove `TxGraph::insert_txout_preview`
  Remove `TxGraph::insert_tx_preview`
  Remove `insert_anchor_preview`
  Remove `insert_seen_at_preview`

  ### Notes to reviewers

  I'm not sure whether we want to keep `TxGraph::determine_changeset` public or not

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK 62f253103c3fd158ad66a0bba11399e7083226f2

Tree-SHA512: 401bdf49c5f2082971cfcd5... (continued)

161 of 161 new or added lines in 8 files covered. (100.0%)

8034 of 10207 relevant lines covered (78.71%)

215474.36 hits per line