bitcoindevkit / bdk / 7727712200

84%

push

github

Merge bitcoindevkit/bdk#1267: Simplify `Esplora::update_local_chain` and add tests

<a class=hub.com/bitcoindevkit/bdk/commit/c5afbaa95d7bc699981d6fe7f9964a41b7587d5c">c5afbaa95<a href="https://github.com/bitcoindevkit/bdk/commit/8ad52f720f7da8987ef1f7a7a30fcb6abd381225"> ci: update zstd-sys version to work with MSRV 1.63 (Steve Myers)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/929b5ddb0c2e0dc7c346c08888201ac54efab84d">929b5ddb0</a><a href="https://github.com/bitcoindevkit/bdk/commit/8ad52f720f7da8987ef1f7a7a30fcb6abd381225"> refactor(esplora): better variable naming and docs (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/216648bcfd2c622890bf7f50fb2eaa4396c42ed1">216648bcf</a><a href="https://github.com/bitcoindevkit/bdk/commit/8ad52f720f7da8987ef1f7a7a30fcb6abd381225"> chore(esplora): Clarify consistency guarantees (LLFourn)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/63fa710319f231f7f28d92cb49b0399f3250c9da">63fa71031</a><a href="https://github.com/bitcoindevkit/bdk/commit/8ad52f720f7da8987ef1f7a7a30fcb6abd381225"> fix(esplora): reuse returned height instead of zipping (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/6f824cf325c6c882b00742d814be1d72602f05a6">6f824cf32</a><a href="https://github.com/bitcoindevkit/bdk/commit/8ad52f720f7da8987ef1f7a7a30fcb6abd381225"> test(esplora): introduce test cases for `update_local_chain` (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/f05e8502e69a051af9869be6ba5ad9a376b25fc2">f05e8502e</a> feat(esplora): greatly simplify `update_local_chain` (志宇)

Pull request description:

  Fixes #1199

  ### Description

  After a second look at the `update_local_chain` implementations, it was clear that they were over complicated. This PR simplifies the `EsploraExt::update_local_chain` method(s) of the `bdk_esplora` crate and adds a whole bunch of tests.

  ### Notes to the reviewers

  The description of #1199 is very brief, however @danielabrozzoni mentioned about potentially-problematic logic with `ASSUME_FINAL_DEPTH`. The logic was indeed convoluted and it did not need to be that way. This PR removes the need for `ASSUME_FINAL_DEPTH`.

  ### Changelog notice

  Fixed
  - Simplified `EsploraExt::update_local_chain` logic.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  ~* [ ] This pull request breaks the existing API~
  ~* [ ] I've added tests to reproduce the issue which are now passing~ (there are now lots of tests though)
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK c5afbaa95d7bc699981d6fe7f9964a41b7587d5c
  notmandatory:
    utACK c5afbaa95d7bc... (continued)

9225 of 11375 relevant lines covered (81.1%)

5700.67 hits per line