bitcoindevkit / bdk / 7617544668

84%

push

github

Merge bitcoindevkit/bdk#1253: Remove deprecated checksum routines

<a class=hub.com/bitcoindevkit/bdk/commit/ed91a4bdb49276057eb7458e1a94653553be24e7">ed91a4bdb<a href="https://github.com/bitcoindevkit/bdk/commit/fbd1d656187859fcb7b84b177e7e9498c15537ea"> Consolidate `calc_checksum_bytes_internal` routine (Sebastian Falbesoner)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/179cfeff51cefda80c16fa4558ba039143a2ad2c">179cfeff5</a> Remove deprecated `get_checksum{,_bytes}` routines (Sebastian Falbesoner)

Pull request description:

  ### Description

  This PR removes the routines `get_checksum` and `get_checksum_bytes` (in the bdk crate, descriptor/checksum.rs), which have been deprecated in 0.24.0. Consequently, the routine `calc_checksum_bytes_internal` is consolidated into `calc_checksum_bytes`, as the boolean parameter `exclude_hash` is not needed anymore. See also the two TODOs in the touched file.

  ### Notes to the reviewers

  In the second commit, the signature of the function `calc_checksum_bytes` slightly changes, as the `desc` parameter now is declared as `mut`, in order to change the local variable within the function. My rust experience is rather limited, so I'm not sure if this is a problem for users. IIUC, this is comparable to changing a pass-by-value parameter in C++ from `const std::string desc` to `std::string desc`, which is relevant only for the function implementation, but doesn't change the interface.

  ### Changelog notice

  - Remove deprecated `get_checksum` and `get_checksum_bytes` routines

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  danielabrozzoni:
    ACK ed91a4bdb49276057eb7458e1a94653553be24e7

Tree-SHA512: a29ead57db3a6a336cddd7b40a4383e1084

8968 of 11227 relevant lines covered (79.88%)

5917.94 hits per line