Ran
|
Jobs
1
|
Files
40
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
push
github
Merge bitcoindevkit/bdk#1402: [wallet] Improve address API d39b319dd test(wallet): Test wallet addresses (valued mammal) a266b4718 chore(wallet)!: Remove enum AddressIndex (valued mammal) d87874780 refactor(wallet)!: Remove method get_address (valued mammal) d3763e5e3 feat(wallet): Add new address methods (valued mammal) Pull request description: Improvements to the wallet address API, see commit messages for details. ### Notes to the reviewers The logic of getting addresses is roughly the same as before when using `AddressIndex`, following this mapping: - `New` -> `reveal_next_address` - `LastUnused` -> `next_unused_address` (assuming this is what `LastUnused` really means) - `Peek` -> `peek_address` Wondering whether it makes sense to expose [`is_used`](https://github.com/bitcoindevkit/bdk/blob/358e842dc/crates/chain/src/keychain/txout_index.rs#L236) for Wallet as well. fixes #898 ### Changelog notice Added: - Added Wallet methods: - `peek_address` - `reveal_next_address` - `next_unused_address` - `reveal_addresses_to` - `list_unused_addresses` - `mark_used` - `unmark_used` Removed: - Removed Wallet methods: - `get_address` - `get_internal_address` - `try_get_address` - `try_get_internal_address` - Removed type AddressIndex ### Checklists * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ### Feature * [x] I've added tests for the new feature * [x] I've added docs for the new feature * [x] This pull request breaks the existing API * [x] I'm linking the issue being fixed by this PR ACKs for top commit: evanlinjin: ACK d39b319ddf6bf3... (continued)
67 of 67 new or added lines in 1 file covered. (100.0%)
9628 of 11365 relevant lines covered (84.72%)
18357.69 hits per line
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 8763552024.1 | 40 |
84.72 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|