bitcoindevkit / bdk / 8385564609

79%

push

github

Merge bitcoindevkit/bdk#1310: Remove extra taproot fields when finalizing PSBT

<a class=hub.com/bitcoindevkit/bdk/commit/5840ce473e430de4c4e3698734e9667cc476fee4">5840ce473<a href="https://github.com/bitcoindevkit/bdk/commit/0eb1ac2bcbaf49c000a0c76a899a356b49cbb50f"> fix(bdk): Remove extra taproot fields when finalizing Psbt (vmammal)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/8c78a42163dee06b640f46d74255df37dbc53873">8c78a4216</a> test(psbt): Fixup test_psbt_multiple_internalkey_signers (vmammal)

Pull request description:

  We currently allow removing `partial_sigs` from a finalized PSBT, which is relevant to non-taproot inputs, however taproot related PSBT fields were left in place despite the recommendation of BIP371 to remove them once the `final_script_witness` is constructed. This can cause confusion for parsers that encounter extra taproot metadata in an already satisfied input.

  Fix this by introducing a new member to SignOptions `remove_taproot_extras`, which when true will remove extra taproot related data from a PSBT upon successful finalization. This change makes removal of all taproot extras the default but configurable.

  fixes #1243

  ### Notes to the reviewers

  If there's a better or more descriptive name for `remove_taproot_extras`, I'm open to changing it.

  ### Changelog notice

  Fixed an [issue](https://github.com/bitcoindevkit/bdk/issues/1243) finalizing taproot inputs following BIP371

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  <!-- * [ ] This pull request breaks the existing API -->
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK 5840ce473e430de4c4e3698734e9667cc476fee4

Tree-SHA512: 69f022c6faf6a2c67970c4e71691f9030c3

15 of 15 new or added lines in 2 files covered. (100.0%)

9113 of 11175 relevant lines covered (81.55%)

5758.66 hits per line