bitcoindevkit / bdk / 10377091809

79%

push

github

Merge bitcoindevkit/bdk#1491: Enable selecting use-rustls-ring feature on electrum client

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/f965f95721c719ac755da07aa997d9b858583856">f965f9572 feat: enable selecting use-rustls-ring feature on electrum client (thunderbiscuit)

Pull request description:

  This PR is a companion to bitcoindevkit/rust-electrum-client#135. It enables choosing the `ring` dependency on rustls instead of the new default (as of 0.23.0) `aws-lc-rs`. The AWS dependency breaks the Android and Swift builds. I wrote a more detailed explanation on [#135](https://github.com/bitcoindevkit/rust-electrum-client/pull/135).

  ### Notes to the reviewers

  Do not merge before:
  - [x] [#135](https://github.com/bitcoindevkit/rust-electrum-client/pull/135) is merged
  - [x] A new version of rust-electrum-client is released (will be 0.21.0)
  - [x] The dependency points to the new version of the client rather than my fork of it.

  ### Changelog notice

  ```md
  Added
      - bdk_electrum now enables choosing either the `use-rustls` or `use-rustls-ring` feature
  ```

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  LLFourn:
    ACK f965f95721c719ac755da07aa997d9b858583856
  notmandatory:
    utACK f965f95721c719ac755da07aa997d9b858583856
  oleonardolima:
    ACK f965f95721c719ac755da07aa997d9b858583856

Tree-SHA512: c82afa82ebce0901821de1931a76c09aa4b

10915 of 13340 relevant lines covered (81.82%)

13295.44 hits per line