bitcoindevkit / bdk / 11946034661

83%

push

github

Merge bitcoindevkit/bdk#1730: Check time when persisting in `rusqlite` impl

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/8ec9c0a7495acc2cdc6f4444d1a1d3aca566b17b">8ec9c0a74 fix(chain): check time when persisting (Rob N)

Pull request description:

  Closes #1713

  Any implementation overflowing the `i64` type would be clearly faulty, so I just pass up the error if the conversion fails.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK 8ec9c0a7495acc2cdc6f4444d1a1d3aca566b17b
  oleonardolima:
    utACK 8ec9c0a7495acc2cdc6f4444d1a1d3aca566b17b

Tree-SHA512: ded7c036ff37fdfd0f6c7aadb7e79d77b00

0 of 2 new or added lines in 1 file covered. (0.0%)

11514 of 13893 relevant lines covered (82.88%)

18312.55 hits per line