bitcoindevkit / bdk / 12992164701

79%

push

github

Merge bitcoindevkit/bdk#1812: fix(wallet): use `map_keychain` in `Wallet::build_fee_bump`

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/515309e99fb92335a35ef994839a37a26f23ea69">515309e99<a href="https://github.com/bitcoindevkit/bdk/commit/ab4df298a41790252ccfe2ca04aacc4c7d84eb4b"> test(wallet): test `build_fee_bump` with single descriptor wallet (valued mammal)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/53d16e1b38eabee1f1ca304933a818951b8b0f43">53d16e1b3</a> fix(wallet): use `map_keychain` in `Wallet::build_fee_bump` (valued mammal)

Pull request description:

  Previously we failed to remove the change output if the wallet has no internal keychain which caused tx building to fail at the new higher feerate. Fix this by mapping the internal keychain to the de-facto change keychain so that the drain output can be recalculated.

  fixes #1807

  ### Changelog notice

  Fixed

  - wallet: Fixed an issue preventing `build_fee_bump` from re-targeting the drain value for some wallets

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK 515309e99fb92335a35ef994839a37a26f23ea69
  evanlinjin:
    ACK 515309e99fb92335a35ef994839a37a26f23ea69

Tree-SHA512: 53266c4b075e8bd1216452aea792ea5be19

41 of 41 new or added lines in 2 files covered. (100.0%)

12021 of 13976 relevant lines covered (86.01%)

20834.11 hits per line