wikimedia / parsoid / 2388

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/9f0780d8c">Use instanceof for token types

instanceof works, and implemented efficiently: the class_entry*
for the RHS is cached in the opline, so it just has to walk the
inheritance chain for the LHS, which is usually pretty short.

For memory efficiency, remove Token::$type, just get it from reflection
since it is always equal to the class name.

Remove TokenUtils::isOfType() since it is adequately served by
instanceof and is_string(). Leave in getTokenType(), since although it
has no remaining callers, it could conceivably be useful.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/8ba4f9f6a">8ba4f9f6a</a>

9553 of 12024 branches covered (79.45%)

14868 of 17609 relevant lines covered (84.43%)

86180.42 hits per line