wikimedia / parsoid / 2537

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/7dee7f51f">Fix console.assert when running under node &gt;= 0.10

For browser compatibility (I guess) in Node v10, console.assert() was
changed to log messages to stderr *WITHOUT THROWING AN EXCEPTION*.
That interacts poorly with our service framework, which relies on
exception handling to return error pages, and with various places
in our code which assume that console.assert() can&#39;t fall through.

In theory we should probably switch to a &quot;better&quot; assertion library.
But since we don&#39;t use console.assert very much anyway, and we&#39;re
switching to PHP (with its own assertion library), for the moment
just hack console.assert() to ensure it throws an exception the
way it always used to.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/223370d23">223370d23</a>

9557 of 12045 branches covered (79.34%)

14772 of 17537 relevant lines covered (84.23%)

94168.24 hits per line