wikimedia / parsoid / 3116

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/942e89096">Link prefix fixes for Parsoid/PHP

Parsoid/PHP was missing the `D` regexp modifier when creating a link prefix
regexp from a character set, which caused the prefix to jump over newlines.

While auditing, noticed that the PHP prefix/trail regexps also contain the
`s` modifier (DOTALL).  However, node v6 doesn&#39;t support the `s` modifier,
and it appears that this is just used to handle the &quot;bit after the link
trail&quot; in the regexp -- the link trail for enwiki for example is:
```
   /^([a-z]+)(.*)$/sD
```

We actually strip the `(.*)$` part out in
WikiConfig.js::buildLinkNeighborRegex() and SiteConfig.php::linkTrailRegex()
so the `s` modifier should be unnecessary in both Parsoid/JS and Parsoid/PHP.

Bug: T236183
Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/b4df6ed1d">b4df6ed1d</a>

19222 of 24160 branches covered (79.56%)

30154 of 35544 relevant lines covered (84.84%)

99215.48 hits per line