wikimedia / parsoid / 2354

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/ea80d1b68">PEG rule parameters

Modify the grammar to replace stops with rule parameters, which is a new
feature I am adding to our PEG.js fork &quot;WikiPEG&quot;.

See README.md of WikiPEG for the syntax.

* Switch to the rebranded PEG.js fork now called WikiPEG
  - Updated package.json &amp; npm-shrinkwrap.json
* Remove SyntaxStops, replace all stops with parameters
* In isXMLTag(), instead of returning the ext tag status by pushing a
  stop, split out isExtTag() to a separate function and call it in a
  separate predicate.
* Split xmlish_tag, adding a new parameterized part xmlish_tag_opened,
  which is called once with extTag=true, and if that fails, again with
  extTag=false. So when extTag=true, we call isExtTag(). This allows
  extTag to be set correctly for referenced rules. Same with block_tag.
* Move the character class regex from inlineBreaks() to the calling rule
  inline_breaks, in order to avoid the overhead of capturing many
  parameters on every invocation. It&#39;s probably faster to inline it
  anyway since the technique is the same.
* preproc and th were the only remaining stops which were not strictly
  scoped to the rule that modifies them. So they become reference
  parameters.
* Change preproc from an integer back to a string. I originally changed
  it to an integer, imagining all parameters would be integers, but for
  reference parameters the underlying type is mixed, and it&#39;s easier to
  have a string literal in the grammar than a symbolic constant
  referring to an integer.
* Add several rules of the form *_parameterized. Since parameters can
  only be set in rule references, if there&#39;s a lot of separate rule
  references that need the same parameters, it is tedious to have an
  assignment in every one. Splitting out a parameterized rule allows the
  parameter to be set only once and shared between subsequent calls.

Change-Id: I</a>... (continued)

9429 of 11857 branches covered (79.52%)

14859 of 17579 relevant lines covered (84.53%)

85718.93 hits per line