wikimedia / parsoid / 3065

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/666d1f1d0">Use PHPUtils::lastItem() over end() in more places

Tim Starling has indicated in couple different places that end(..)
is not preferred and he had implemented a private version of lastItem
in the PEG grammar code whereas PHPUtils::lastItem was recommending
use of end(..).

In this patch, I moved the implementation from the grammar to PHPUtils
and replaced end(..) with PHPUtils::lastItem in a number of places in
the codebase. We should discuss whether we want to use this helper
everywhere.

Resolved a couple of PORT-FIXMEs in the bargain.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/837f2a980">837f2a980</a>

19272 of 24294 branches covered (79.33%)

30162 of 35572 relevant lines covered (84.79%)

99187.15 hits per line