wikimedia / parsoid / 2649

85%

push

travis-ci

Handle dataAttribs->a and dataAttribs->sa consistently in tokens & nodes

* DOMDataUtils::loadDataAttribs was initializing dp->a and dp->sa
  as objects.

* But, Tokens::setShadowInfo was initializing dataAttribs->a and ->sa
  as arrays.

* During wikitext serialization, nodes are converted to tokens. This
  introduced failures because of the above inconsistency.

* This patch treats them as arrays in Tokens ($token->dataAttribs)
  as well as DOMNodes (DOMDataUtils::getDataParsoid($node))

* Verified that the changes to ComputeDSR doesn't break that pass by
  running hybrid tests with that pass enabled and confirming all tests
  continue to pass.

Change-Id: Ia2aed090d

9198 of 12006 branches covered (76.61%)

14597 of 17628 relevant lines covered (82.81%)

28645.94 hits per line