wikimedia / parsoid / 3021

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/6fbdd7038">Clear invalid DSRs in &lt;poem&gt;

The poem extension munges its contents before parsing it as wikitext.
This means that the parsed content doesn&#39;t appear literally in the
source document -- therefore we need a new parsing frame.  In addition,
we should clear the DSR in the result, since we are not currently
correctly mapping these DSRs to offsets in the source document, and
so they can&#39;t be used for selser.

If we ever implement selser on the &lt;poem&gt; contents, we simply need
to record the mapping to original $contents as we preprocess it,
and then apply this mapping to the DOM result, the same way we do
for the gallery extension.

This off-by-one error was present in both the PHP and JS implementations,
although only the PHP implementation triggered an assertion failure
because (a) in JavaScript you&#39;d have to use emojis or other astral symbols,
and (b) the JavaScript implementation doesn&#39;t do unicode offset consistency
checks, so you&#39;d have to examine the DSR offsets directly to see the
bug; since we don&#39;t do selser on &lt;poem&gt; contents the bad DSR offsets
can&#39;t actually cause a bad html2wt result.

You can see the bad DSR and one-character-shifted template parameter data-mw
contents in the HTML generated by the JavaScript implementation before this
patch, however.  Parser test added to document/prevent regression.

Bug: T231945
Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/86f5c27bf">86f5c27bf</a>

19282 of 24282 branches covered (79.41%)

30146 of 35550 relevant lines covered (84.8%)

96869.74 hits per line