wikimedia / parsoid / 2551

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/1c9e57e70">Fix phan issues found by phan 1.3.2

The latest version of phan throws some lint errors which phan 1.3.1 did not.

These appear to mostly be false positives; tighter types on the variables
involved remove most of them.

SiteConfig seems to show a phan bug, however: the late initialization of
SiteConfig::nsNames in SiteConfig::loadSiteData (and in particular, the
initial `$this-&gt;nsNames = []` statement) appears to confuse phan about
the type of the `nsNames` property, completely overriding the type set
by the `@var` annotation at the declaration site.  Moving the
initializations to the constructor works around this problem.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/04b3fb835">04b3fb835</a>

9546 of 12039 branches covered (79.29%)

14922 of 17691 relevant lines covered (84.35%)

93042.0 hits per line