wikimedia / parsoid / 3083

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/0b6df203c">Bug fix populating functionhooks in SiteConfig + bunch of cleanup

* Removed some variables from extension SiteConfig that became dead
  since d3ef20941.

* Trailing colon wasn&#39;t being stripped properly while setting up
  functionhooks which led to failures looking up DEFAULTSORT in the
  functionhooks map which caused the failure in T235004.

  The functionhooks property wasn&#39;t being set up correctly all the
  time either.

* Cleaned up API SiteConfig code to expose duplicated code in the
  API and extension SiteConfig objects. This code needs to be refactored
  and some of the common code needs to be moved to the base class.

  This is left for a followup.

* Separately, it is unclear (a) why we need to the laborious job of setting
  up the functionhooks and variables array (b) and if this is actually being
  used beyond looking up the defaultsort value. Maybe, something simpler
  can solve our restricted use case.

* Additionally, Scott points out in a review that the case-insensitive words
  aren&#39;t handled correctly (both in JS and now here in PHP).

  This is left for a followup (maybe after addressing the complaints
  above since addressing them could potentially simplify what needs
  to be done).

Bug: T235004
Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/8e93d821d">8e93d821d</a>

19272 of 24294 branches covered (79.33%)

30164 of 35574 relevant lines covered (84.79%)

99189.99 hits per line