wikimedia / parsoid / 2702

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/3403a4fae">Tweaks to TemplateHandler

* We were using a generic object instead of constructing a KV object
  in one place. While this works in JS land, better to fix it.

* state.resolveTemplateTarget seems to be always undefined - so, get rid
  of the unnecessary check for it.

  Turns out that this was a typo for state.resolvedTemplateTarget from
  9b03cdab7. However, it turns out to have been a fortuitous typo
  because the if-condition 9b03cdab7 added to avoid seemingly unnecessary
  resolution of the target was buggy.

  This code patch is only exercised in the parser tests case where
  _expandTemplate is called. But, before _expandTemplate is called, the
  token&#39;s attributes are expanded =&gt; the previous resolved target for
  the the template might be incorrect. This is in fact the case for
  when the template target itself is templated. So, when I fixed the
  typo and added back the check, these tests failed.

  So, removal of that if-condition is in fact the correct resolution.

* At a number of places in TemplateHandler.js where &#39;expandTemplates&#39;
  is used, the check is actually for whether we should encapsulate the
  template tokens with meta tags. So, introduced a wrapTemplates property
  that is computed from the inTemplate property. This change makes the
  logic a bit more clearer without changing the functionality itself.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/0816b1383">0816b1383</a>

9540 of 12025 branches covered (79.33%)

14918 of 17646 relevant lines covered (84.54%)

90411.73 hits per line