wikimedia / parsoid / 2661

85%

push

travis-ci

LinkHandlerUtils: Fix translation of non-boolean JS &&/||

The JS side had

 var sizeString = (size && size.ak) || (ww.fromDataMW && ww.value);

in JS this takes the value of size.ak or ww.value (or something falsey).
The naively translated PHP, on the other hand, always results in true
or false. We need more complicated logic to duplicate the JS behavior.

Further, we may also need to take into account here the fact that in JS
string-0 is truthy while in PHP it's falsey.

Also, apparently Phan was confused all this time about what $getLastOpt
could return, and the changed code structure made it start complaining.
A typehint fixes that.

Change-Id: I26fb19323

9198 of 12006 branches covered (76.61%)

14597 of 17628 relevant lines covered (82.81%)

28646.21 hits per line