wikimedia / parsoid / 2611

85%

push

travis-ci

PreHandler: Fix resetState implementation

* The Prehandler's resetState was a bit strange. It used the pre-handler's
  constructor options to reset state and ignored the input argument.

  Probably because of this, the PHP port introduced a bug by using $opts
  to reset state without realizing that $this->options and $opts may not
  be identical.

* Anyway, the confusion is probably because of the mixed up implementation
  of resetState. It is mixing one-time constructor based reset with a
  reset based on reusing the pipeline.

  This patch fixes it by separating the two resets.

Change-Id: I38036a4dc

9535 of 12024 branches covered (79.3%)

14915 of 17676 relevant lines covered (84.38%)

90114.68 hits per line