wikimedia / parsoid / 2724

85%

push

travis-ci

Bunch of bug fixes in recently ported files

* Enabled newly ported js-async token transformers in the parser
  pipeline factory.

* TokenUtils::tokensToString didn't faithfully implement the JS
  implementation. While it forced an array argument for tokens
  presumably based on the comment on the JS side, I immediately found
  two sites that would have to duplicate the is_string/is_array
  checks. So, I updated tokensToString to not assume $token is an array.

  I went ahead and updated several call sites to simplify the calls
  to remove redundant checks that is now covered by the tokensToString
  checks.

  Added a number of phan-suppress annotations in the function since it
  isn't clear why phan is complaining.

* Added a FIXME around another discrepancy in the use of trim()
  in TemplateHandler::lookupArg.

* Bug fixes in DOMFragmentBuilder, ExtensionHandler, and ExternalLinkHandler.
  * Added missing code in DOMFragmentBuilder
  * Fixed onTag signature in ExternalLinkHandler

* Removed dead code in TokenStreamPatcher.

* Encountered all these while trying to parse a number of transclusions
  from enwiki:Barack_Obama page.

  More debugging needed. Till all js-async token transformers are ported
  and enabled, we cannot really run tests and debug properly, so
  stopping at this point.

Change-Id: Ifaebecd35

9607 of 12014 branches covered (79.97%)

15053 of 17645 relevant lines covered (85.31%)

91620.3 hits per line