wikimedia / parsoid / 2691

85%

push

travis-ci

<a href="https://github.com/wikimedia/parsoid/commit/eaf890470">Followup to 2a2d8799: Improve DSR computation precision

* I noticed new cs/s DSR inconsistency warnings while testing
  PHP htm2wt code. It turns out that &lt;figcaption&gt; DSR values were
  incorrect in some cases, Ex: [[File:Foobar.jpg|right|Caption|200px]]

  In that example, the 200px isn&#39;t present in the DOM subtree
  of &lt;figure&gt; which confuses the DSR computation.

* It turns out that there is some really old defensive code in DSR
  computation which ignores tsr[1] value and prefers a computed
  value conditionally.

  Since our tsr/dsr computation code has lot of its bugs shaken out,
  I removed that defensive code and preferred tsr[1] if set and if
  it is the right thing to pick (if the tsr value spans the entire
  DOM subtree). That required me to improve the tsrSpansTagDOM
  function.

  While at it, I added tag widths for language variant markup and
  updated parser tests that had &#39;null&#39; value set.

* The parser test blacklist changes are all improvements. Specifically,
  note the change in &quot;SVG thumbnails with invalid language code&quot;.
  The figcaption offset is correct now compared to the incorrect value
  previously.

* This change also eliminates the FIGCAPTION cs/s DSR inconsistency
  warnings that triggered this inspection.

Change-Id: I</a><a class="double-link" href="https://github.com/wikimedia/parsoid/commit/e5f24f347">e5f24f347</a>

9536 of 12011 branches covered (79.39%)

14913 of 17628 relevant lines covered (84.6%)

90364.39 hits per line