wikimedia / parsoid / 2514

85%

push

travis-ci

WTS: Get rid of unnecessary double-newline normalization

* That check was there presumably to prevent bare-text nodes
  provided by clients from serializing to wikitext that will then
  parse back to HTML, i.e. to maintain html2html fidelity for
  this use case.

  But, we have long since given up the idea of trying to support
  arbitrary HTML at this time and are only guaranteed to generate
  reasonable wikitext for HTML that conform to Parsoid specs.

  For one, this clause adds unnecessary complexity for questionable
  benefits. For another, this is introducing spurious newline diffs
  during JS-PHP hybrid testing because of the idiosyncracies of how
  text nodes might get split up by diff meta tags. So, if two text nodes
  are split up by a diff meta tag, this newline normalization no longer
  applies.

* Fixes a bunch of cite test failures.

Change-Id: Ic9a4cfa06

9515 of 12008 branches covered (79.24%)

14753 of 17511 relevant lines covered (84.25%)

90077.87 hits per line