grpc / grpc-java

89%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• LoadStatsData
• android
• creamsoup-patch-1
• creamsoup-patch-2
• dapengzhang0-patch-1
• dapengzhang0-patch-2
• dependabot/maven/examples/example-gauth/junit-junit-4.13.1
• dependabot/maven/examples/example-hostname/junit-junit-4.13.1
• dependabot/maven/examples/example-jwt-auth/junit-junit-4.13.1
• expose-census-interceptors
• fault-inject-interop-test
• fix-server-builder-javadoc
• java_qps_take_two
• jcenter-shutdown
• jtattermusch-patch-1
• kannanjgithub-patch-1
• master
• prevents-exception-allocation-on-channel-shutdown
• ran-su-patch-1
• releasing-internal-steps
• remove-netty-min-buffer-size
• revert-12099-backport-1.71-xds_http_connect
• revert-4813-mvn-google-mirror
• revert-6233-v1.24.x
• revert-7720-delayed-stream
• revert-7799-interop-test
• tweaking_java_qpsworker
• typo
• updates-retry-behavior-for-redefinition-in-A6
• v0.12.x
• v0.13.0
• v0.13.1
• v0.13.2
• v0.13.x
• v0.14.0
• v0.14.1
• v0.14.x
• v0.15.0
• v0.15.x
• v0.8.x
• v0.9.x
• v1.0.0
• v1.0.0-pre1
• v1.0.0-pre2
• v1.0.2
• v1.0.3
• v1.0.x
• v1.1.0
• v1.1.1
• v1.1.2
• v1.1.x
• v1.10.0
• v1.10.1
• v1.10.x
• v1.11.0
• v1.11.x
• v1.15.0
• v1.15.1
• v1.15.x
• v1.16.0
• v1.16.1
• v1.16.x
• v1.17.0
• v1.17.1
• v1.17.2
• v1.17.x
• v1.18.0
• v1.18.x
• v1.19.0
• v1.19.x
• v1.2.0
• v1.2.x
• v1.20.0
• v1.20.x
• v1.21.0
• v1.21.x
• v1.22.0
• v1.22.1
• v1.22.3
• v1.22.x
• v1.23.1
• v1.23.x
• v1.24.0
• v1.24.1
• v1.24.2
• v1.24.x
• v1.25.0
• v1.25.x
• v1.26.0
• v1.26.1
• v1.26.x
• v1.27.0
• v1.27.1
• v1.27.2
• v1.27.x
• v1.28.0
• v1.28.1
• v1.28.x
• v1.29.0
• v1.29.x
• v1.3.x
• v1.30.0
• v1.30.1
• v1.30.2
• v1.30.x
• v1.31.0
• v1.31.1
• v1.31.2
• v1.31.x
• v1.32.0
• v1.32.1
• v1.32.2
• v1.32.3
• v1.32.x
• v1.33.0
• v1.33.1
• v1.33.x
• v1.34.0
• v1.34.1
• v1.34.x
• v1.35.0
• v1.35.1
• v1.35.x
• v1.36.0
• v1.36.1
• v1.36.2
• v1.36.x
• v1.37.0
• v1.37.1
• v1.37.x
• v1.38.0
• v1.38.x
• v1.4.0
• v1.4.x
• v1.5.0
• v1.5.x
• v1.55.x
• v1.56.x
• v1.57.x
• v1.58.x
• v1.59.x
• v1.6.1
• v1.6.x
• v1.60.x
• v1.61.x
• v1.62.x
• v1.63.x
• v1.64.x
• v1.65.x
• v1.66.x
• v1.67.x
• v1.68.x
• v1.69.x
• v1.7.1
• v1.7.x
• v1.70.x
• v1.71.x
• v1.72.x
• v1.73.x
• v1.74.x
• v1.8.0
• v1.8.x
• v1.9.0
• v1.9.1
• v1.9.x
• xds-demo
• xds-interop-test
• xds-k8s-cluster-override
• xds-k8s-public-preview-ready-cluster
• xds-k8s-switch-cluster
• xds-k8s-timeout
• xds-resolver-routing-config
• xds-server-channelz
• xds-staging
• zhangkun83-patch-1
• zpencer/proxy_auth_rebase

Build # #19899

Build Type

push

github

Committed by web-flow

Commit Message

core: grpc-timeout should always be positive (#12201)

PROTOCOL-HTTP2.md specifies "TimeoutValue → {positive integer as ASCII
string of at most 8 digits}". Zero is not positive, so it should be
avoided. So make sure timeouts are at least 1 nanosecond instead of 0
nanoseconds.

grpc-go recently began disallowing zero timeouts in
https://github.com/grpc/grpc-go/pull/8290 which caused a regression as
grpc-java can generate such timeouts. Apparently no gRPC implementation
had previously been checking for zero timeouts.

Instead of changing the max(0) to max(1) everywhere, just move the max
handling into TimeoutMarshaller, since every caller of TIMEOUT_KEY was
doing the same max() handling.

Before fd8fd517d (in 2016!), grpc-java actually behaved correctly, as it
failed RPCs with timeouts "<= 0". The commit changed the handling to the
max(0) handling we see now.

b/427338711

Run Details

34643 of 39136 relevant lines covered (88.52%)

0.89 hits per line