#19252
89%

Ran 28 May 2024 10:55PM UTC

Jobs 1

Files 578

Run time 1min

Badge

Embed ▾

Committed 28 May 2024 10:47PM UTC coverage: 88.443% (+0.01%) from 88.433%

Build # #19252

Build Type

push

github

Committed by

web-flow

Commit Message

inprocess: Fix listener race if transport is shutdown while starting

Returning the runnable did nothing, as both the start method and the
runnable are run within the synchronization context. I believe the
Runnable used to be required in the previous implementation of
ManagedChannelImpl (the lock-based implementation before we created
SynchronizationContext).

This fixes a NPE seen in ServerImpl because the server expects proper
ordering of transport lifecycle events.
```
Uncaught exception in the SynchronizationContext. Panic!
java.lang.NullPointerException: Cannot invoke "java.util.concurrent.Future.cancel(boolean)" because "this.handshakeTimeoutFuture" is null
	at io.grpc.internal.ServerImpl$ServerTransportListenerImpl.transportReady(ServerImpl.java:440)
	at io.grpc.inprocess.InProcessTransport$4.run(InProcessTransport.java:215)
	at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:94)
```

b/338445186

Run Details

32057 of 36246 relevant lines covered (88.44%)

0.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	97.35	-0.88%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpServerStream.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
26	92.82	-0.05%	../inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19252.1	28 May 2024 10:55PM UTC	578	88.44

grpc / grpc-java / #19252
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19252

grpc / grpc-java / #19252 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19252

grpc / grpc-java / #19252
89%

README BADGES
x