#19848
89%

Ran 05 Jun 2025 10:17AM UTC

Jobs 1

Files 615

Run time 3min

Badge

Embed ▾

Committed 05 Jun 2025 10:07AM UTC coverage: 88.618%. First build

Build # #19848

Build Type

push

github

Committed by

web-flow

Commit Message

xds: Don't allow hostnames in address field (#12123)

* xds: Don't allow hostnames in address field

gRFC A27 specifies they must be IPv4 or IPv6 addresses. Certainly doing
a DNS lookup hidden inside the config object is asking for trouble.

The tests were accidentally doing a lot of failing DNS requests greatly
slowing them down. On my desktop, which made the problem most obvious
with five search paths in /etc/resolv.conf, :grpc-xds:test decreased
from 66s to 29s. The majority of that is XdsDependencyManagerTest which
went from 33s to .1s, as it generated a UUID for the in-process
transport each test and then used it as a hostname, which defeated
Java's DNS (negative) cache. The slowness was noticed because
XdsDependencyManagerTest should have run quickly as a single thread
without I/O, but was particularly slow on my desktop.

The cleanup caused me to audit serverName and the weird places it went.
I think some of them were tricks for XdsClientFallbackTest to squirrel
away something distinguishing, although reusing the serverName is asking
for confusion as is including the tricks in "shared" utilities.
XdsClientFallbackTest does have some non-trivial changes, but this seems
to fix some pre-existing bugs in the tests.

* Add failing hostname unit test

Run Details

34787 of 39255 relevant lines covered (88.62%)

0.89 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19848.1	05 Jun 2025 10:17AM UTC	615	88.62

grpc / grpc-java / #19848
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #19848

grpc / grpc-java / #19848 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #19848

grpc / grpc-java / #19848
89%

README BADGES
x