#19548
89%

Ran 11 Nov 2024 09:26PM UTC

Jobs 1

Files 616

Run time 2min

Badge

Embed ▾

Committed 11 Nov 2024 09:16PM UTC coverage: 84.61% (+0.005%) from 84.605%

Build # #19548

Build Type

push

github

Committed by

ejona86

Commit Message

util: Remove EAG conveniences from MultiChildLb

This is a step toward removing ResolvedAddresses from ChildLbState,
which isn't actually used by MultiChildLb. Most usages of the EAG usages
can be served more directly without peering into MultiChildLb's
internals or even accessing ChildLbStates, which make the tests less
sensitive to implementation changes. Some changes do leverage the new
behavior of MultiChildLb where it preserves the order of the entries.

This does fix an important bug in shutdown tests. The tests looped over
the ChildLbStates after shutdown, but shutdown deleted all the children
so it looped over an entry collection. Fixing that exposed that
deliverSubchannelState() didn't function after shutdown, as the listener
was removed from the map when the subchannel was shut down. Moving the
listener onto the TestSubchannel allowed having access to the listener
even after shutdown.

A few places in LeastRequestLb lines were just deleted, but that's
because an existing assertion already provided the same check but
without digging into MultiChildLb.

Run Details

34091 of 40292 relevant lines covered (84.61%)

0.85 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	77.08	-1.04%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
2	90.53	1.65%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
4	97.18	1.16%	../util/src/main/java/io/grpc/util/MultiChildLoadBalancer.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
13	88.89	-0.28%	../xds/src/main/java/io/grpc/xds/LeastRequestLoadBalancer.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19548.1	11 Nov 2024 09:26PM UTC	616	84.61

grpc / grpc-java / #19548
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19548

grpc / grpc-java / #19548 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19548

grpc / grpc-java / #19548
89%

README BADGES
x