grpc / grpc-java / #19205
89%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 573
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.341% (-0.02%) from 88.358%
#19205

push

github

ejona86 
opentelemetry: Add optional grpc.lb.locality to per-call metrics

The optional label API was added in 4c78a974 and xds_cluster_impl was
plumbed in 077dcbf9.

From gRFC A78:

> ### Optional xDS Locality Label
>
> When xDS is used, it is desirable for some metrics to include an optional
> label indicating which xDS locality the metrics are associated with.
> We want to provide this optional label for the metrics in both the
> existing per-call metrics defined in [A66] and in the new metrics for
> the WRR LB policy, described below.
>
> If locality information is available, the value of this label will be of
> the form `{region="${REGION}", zone="${ZONE}", sub_zone="${SUB_ZONE}"}`,
> where `${REGION}`, `${ZONE}`, and `${SUB_ZONE}` are replaced with the
> actual values.  If no locality information is available, the label will
> be set to the empty string.
>
> #### Per-Call Metrics
>
> To support the locality label in the per-call metrics, we will provide
> a mechanism for LB picker to add optional labels to the call attempt
> tracer.  We will then use this mechanism in the `xds_cluster_impl`
> policy's picker to set the locality label. ...
>
> This label will be available on the following per-call metrics:
> - `grpc.client.attempt.duration`
> - `grpc.client.attempt.sent_total_compressed_message_size`
> - `grpc.client.attempt.rcvd_total_compressed_message_size`

31558 of 35723 relevant lines covered (88.34%)

0.88 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
96.03
 -0.66% ../core/src/main/java/io/grpc/internal/DelayedClientTransport.java
1
93.77
 -0.16% ../okhttp/src/main/java/io/grpc/okhttp/OkHttpServerTransport.java
1
88.07
 -0.41% ../core/src/main/java/io/grpc/internal/DelayedClientCall.java
1
77.08
 -1.04% ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
2
81.05
 0.0% ../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
3
88.57
 -8.57% ../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java
Jobs
ID Job ID Ran Files Coverage
1 #19205.1 573
88.34
Source Files on build #19205