• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

grpc / grpc-java / #19575
89%

Build:
DEFAULT BRANCH: master
Ran 01 Dec 2024 08:06PM UTC
Jobs 1
Files 600
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

27 Nov 2024 07:37PM UTC coverage: 88.572% (-0.01%) from 88.582%
#19575

push

github

web-flow
rls: Reduce RLS channel logging

The channel log is shared by many components and is poorly suited to
the noise of per-RPC events. This commit restricts RLS usage of the
logger to no more frequent than cache entry events. This may still be
too frequent, but should substantially improve the signal-to-noise and
we can do further rework as needed.

Many of the log entries were poor because they lacked enough context.
They weren't even clear they were from RLS. The cache entry events now
regularly include the request key in the logs, allowing you to follow
events for specific keys. I would have preferred using the hash code,
but NumberFormat is annoying and toString() may be acceptable given its
convenience.

This commit reverts much of eba699ad. Those logs have not proven to be
helpful as they produce more output than can be reasonably stored.

33344 of 37646 relevant lines covered (88.57%)

0.89 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
77.08
-1.04% ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
1
94.12
-1.18% ../netty/src/main/java/io/grpc/netty/WriteBufferingAndExceptionHandler.java
1
93.43
-0.16% ../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
6
88.89
-1.65% ../core/src/main/java/io/grpc/internal/DelayedClientCall.java
7
84.0
1.54% ../rls/src/main/java/io/grpc/rls/RlsLoadBalancer.java
34
88.63
-0.21% ../rls/src/main/java/io/grpc/rls/CachingRlsLbClient.java
Jobs
ID Job ID Ran Files Coverage
1 #19575.1 01 Dec 2024 08:06PM UTC 600
88.57
Source Files on build #19575
  • Tree
  • List 600
  • Changed 8
  • Source Changed 0
  • Coverage Changed 8
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #19575
  • 7f9c1f39 on github
  • Prev Build on master
  • Next Build on master
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc