#19410
89%

Ran 09 Aug 2024 10:46PM UTC

Jobs 1

Files 603

Run time 1min

Badge

Embed ▾

Committed 09 Aug 2024 10:38PM UTC coverage: 84.467% (+0.007%) from 84.46%

Build # #19410

Build Type

push

github

Committed by

ejona86

Commit Message

util: SocketAddress.toString() cannot be used for equality

Some addresses are equal even though their toString is different
(InetSocketAddress ignores the hostname when it has an address). And
some addresses are not equal even though their toString might be the
same (AnonymousInProcessSocketAddress doesn't override toString()).

InetSocketAddress/InetAddress do not cache the toString() result. Thus,
even in the worst case that uses a HashSet, this should use less memory
than the earlier approach, as no strings are formatted. It probably also
significantly improves performance in the reasonably common case when an
Endpoint is created just for looking up a key, because the string
creation in the constructor isn't then amorized.
updateChildrenWithResolvedAddresses(), for example, creates n^2 Endpoint
objects for lookups.

Run Details

33270 of 39388 relevant lines covered (84.47%)

0.84 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
7	88.89	-2.06%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19410.1	09 Aug 2024 10:46PM UTC	603	84.47

grpc / grpc-java / #19410
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19410

grpc / grpc-java / #19410 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19410

grpc / grpc-java / #19410
89%

README BADGES
x