#19850
89%

Ran 05 Jun 2025 03:53PM UTC

Jobs 1

Files 615

Run time 4min

Badge

Embed ▾

Committed 05 Jun 2025 03:43PM UTC coverage: 88.616% (-0.03%) from 88.646%

Build # #19850

Build Type

push

github

Committed by

ejona86

Commit Message

xds: Fix XdsDepManager aggregate cluster child ordering and loop detection

The children of aggregate clusters have a priority order, so we can't
ever throw them in an ordinary set for later iteration.

This now detects recusion limits only after subscribing, but that
matches our existing behavior in CdsLoadBalancer2. We don't get much
value detecting the limit before subscribing and doing so makes watcher
types more different.

Loops are still a bit broken as they won't be unwatched when orphaned,
as they will form a reference loop. In CdsLoadBalancer2, duplicate
clusters had duplicate watchers so there was single-ownership and
reference cycles couldn't form. Fixing that is a bigger change.

Intermediate aggregate clusters are now included in XdsConfig, just for
simplicity. It doesn't hurt anything whether they are present or
missing. but it required updates to some tests.

Run Details

34764 of 39230 relevant lines covered (88.62%)

0.89 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	91.37	-0.21%	../netty/src/main/java/io/grpc/netty/NettyServerHandler.java
1	94.12	-1.18%	../netty/src/main/java/io/grpc/netty/WriteBufferingAndExceptionHandler.java
1	93.17	-0.14%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
1	93.47	-0.16%	../okhttp/src/main/java/io/grpc/okhttp/OkHttpServerTransport.java
4	91.9	-1.9%	../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java
5	83.02	-9.43%	../core/src/main/java/io/grpc/internal/Http2Ping.java
6	77.08	-6.25%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
6	92.86	0.09%	../xds/src/main/java/io/grpc/xds/XdsConfig.java
28	92.65	0.65%	../xds/src/main/java/io/grpc/xds/XdsDependencyManager.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#19850.1	05 Jun 2025 03:53PM UTC	615	88.62

grpc / grpc-java / #19850
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19850

grpc / grpc-java / #19850 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #19850

grpc / grpc-java / #19850
89%

README BADGES
x